-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of falsy existing
and/or incoming
parameters in relayStylePagination
#8733
Conversation
what still needs to be taken and merged? @benjamn |
Looks good! Sorry about the delay, this was opened before the break. Let’s get this merged and shipped! |
04c026a
to
6e0ba4a
Compare
Merging even though I believe that test failure is spurious, since that test has been failing recently on |
awesome guys! great job here |
if (!existing) { | ||
existing = makeEmptyData(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Building on #7949 by @bubba, and hopefully fixing #7822.